MyHush / SilentDragonAndroid

Android companion app for SilentDragon
https://www.myhush.org
GNU General Public License v3.0
5 stars 12 forks source link

Missing character in the ZADDR and TADDR on 'Receive' screen #20

Closed gilardh closed 4 years ago

gilardh commented 4 years ago

On the 'Receive' screen:

jahway603 commented 4 years ago

TADDR has correct characters in v 0.5.16, but ZADDR is still missing 6 characters. It looks like ReceiveActivity.kt might be where this needs to get fixed.

jahway603 commented 4 years ago

After testing both cases (with and without) using the wormhole with two different phones running LineageOS 15.1 (Android 8.1), I found the following: (1) both phones displayed TADDR correctly (2) The ZADDR displayed correctly on my smaller screen phone [Spec: 5.2 in 1920 × 1080 pixel resolution (423 ppi)] (3) The ZADDR displayed incorrectly on my larger screen phone [Spec: 5.5 in 2560 x 1440 pixel 16:9 ratio resolution (~538 ppi density)]

Not sure what is causing this minor graphical glitch -- maybe the QR code images need to be sized down?

gilardh commented 4 years ago

After correcting the display problem of TADDR and ZADDR, I tested it to work correctly on an Samsung S9 phone. There is certainly an optimization to be done for the tablets. The TAB TADDR will be deleted soon. It is therefore necessary to optimize only the display of ZADDR addresses on all types of screens.

jahway603 commented 4 years ago

@gilardh I just fixed it by making the QR code smaller and successfully tested it's working as expected on larger display phone :)

jahway603 commented 4 years ago

Closing as resolved in Pull Request #108