search

MyHush / SilentDragonLite

SilentDragonLite - HUSH Lite wallet that supports zaddrs!
https://myhush.org
GNU General Public License v3.0
4 stars 12 forks source link

Please add a png icon to the AppImage #161

Closed probonopd closed 4 years ago

probonopd commented 4 years ago

Describe the bug Hi, thanks for making an AppImage.

Could you please add a 256x256 png to usr/share/icons/hicolor/256x256/apps/SilentDragonLite.png?

This is needed to allow the app to pass verification and to be included in AppImageHub. Thanks for your consideration.

To Reproduce AppImage verification fails:

++file /tmp/.mount_BeingTbvoZno/usr/share/icons/hicolor/256x256/apps/SilentDragonLite.xpm
+ICONSIZE=
+'[' -z '' ']'
+echo 'Could not determine the size of the icon'
Could not determine the size of the icon

Expected behavior

A 256x256 png is in usr/share/icons/hicolor/256x256/apps/SilentDragonLite.png inside the AppImage

Additional context https://github.com/AppImage/appimage.github.io/pull/2055

DenioD commented 4 years ago

Thank you for the hint @probonopd ! I will fix that in the next release

leto commented 4 years ago

@probonopd thanks for reporting this! It's our first AppImage, so we didn't know about that

leto commented 4 years ago

@probonopd we are not giving this release out to users and will likely have another soon, but can you verify for us that the png icon looks correct? https://github.com/MyHush/SilentDragonLite/releases/tag/v1.3.5

Thanks!

leto commented 4 years ago

https://github.com/MyHush/SilentDragonLite/releases/tag/v1.3.6 is our latest

jahway603 commented 4 years ago

I can confirm that a 256x256 png is inside the v1.3.9 AppImage in the location "usr/share/icons/hicolor/256x256/apps/SilentDragonLite.png". @DenioD @leto This should be closed.

DenioD commented 4 years ago

thanks for confirming @jahway603 :+1: I will close this issue