search

MyHush / SilentDragonLite

SilentDragonLite - HUSH Lite wallet that supports zaddrs!
https://myhush.org
GNU General Public License v3.0
4 stars 12 forks source link

Sending memo before contact request is answered breaks encryption #168

Closed leto closed 4 years ago

leto commented 4 years ago

sdl-borken

DenioD commented 4 years ago

This is rly a little bit complicated atm for our users. We should disable the send button while waiting for the response of the contact request, and show a little message like "You can send a message after your partner response".

Since this is our key exchange between Alice and Bob, we have to force the user to wait.

leto commented 4 years ago

@DenioD sounds groovy, we can "fix" this at the GUI layer. Since users can type out their message while they wait, it seems fine for now

leto commented 4 years ago

@DenioD we are enforcing the invariant that "Only contacts can send memos to each other", where Contact Requests are the initial "handshake" and have special handling because of that. This is good for me to explain in the whitepaper

DenioD commented 4 years ago

SDL will now only allow to send a message, if their is one incoming message from this contact (initial request). So this issue should be fixed :+1:

leto commented 4 years ago

@DenioD can you clarify, is this fixed in 1.3.9 or will it be in the next release?

DenioD commented 4 years ago

It's fixed and will be include in the next release (1.3.9)