I noticed that regtest tests could see the mainnet notarization data, which prompted this change. The result of getinfo on regtest mode made no sense, as it said there were 3 blocks total but the last notarized block was 386686 and gave mainnet notarization txid and hash, which are invalid on regtest.
Isolates all NetworkID's to their own notarization data file
Prevents regtest mode modifying mainnet data and vice versa
This leaves the filename unchanged for mainnet, but for other networks, it will look like notarizations_regtest
To verify this works, I deleted all notarizations files, then ran ./qa/pull-tester/rpc-tests.sh dpow and verified that ~/.hush/notarizations_regtest existed and ~/.hush/notarizations had not been created.
I noticed that regtest tests could see the mainnet notarization data, which prompted this change. The result of
getinfoon regtest mode made no sense, as it said there were 3 blocks total but the last notarized block was 386686 and gave mainnet notarization txid and hash, which are invalid on regtest.notarizations_regtestTo verify this works, I deleted all notarizations files, then ran
./qa/pull-tester/rpc-tests.sh dpowand verified that~/.hush/notarizations_regtestexisted and~/.hush/notarizationshad not been created.