MyHush / hush

Hush is a fork of Zcash focused on secure communications
https://myhush.org
Other
67 stars 37 forks source link

Port new concept of "DPoW confs" from KMD #152

Closed leto closed 5 years ago

leto commented 5 years ago

This is a WIP but I wanted to start the conversation. This PR still needs more tests which actually look at rawconfirmations/confirmations result data and a completely new documentation file, describing how to use this new feature, it's ramifications, etc...

TLDR:

It felt heavy-handed to add the entire komodo_utils.h but just grabbing 1 or 2 functions from there led to more dependent functions being necessary, so it was easier to add the entire file.

leto commented 5 years ago

Looks like most stuff from komodo_utils is not needed, because I am doing some unnecessary stuff with komodo_statepointer, so get rid of all that

leto commented 5 years ago

Now that we have passing regtests, I feel this code is ready for dev, we can debug further issues there, were it can be tested with the new getsnapshot code