MyHush / hush

Hush is a fork of Zcash focused on secure communications
https://myhush.org
Other
67 stars 37 forks source link

Add porcelain around generating a new config for a Hush node #23

Closed leto closed 6 years ago

leto commented 7 years ago

This creates a bin/genhushconfig bash script that is idempotent, i.e. it can always be run and it will either create ~/.hush for the first time or do nothing.

This looks and feels a lot better in our INSTALL.md as well

leto commented 7 years ago

My repo has been doing really odd stuff with that contrib/debian/changelog file, I will try to regen this without that....

lludlow commented 7 years ago

Shouldn't we put a check in so we do not overwrite an existing hush.conf? Today not that big of a deal without wallet encryption, but I can see this being an issues when we overwrite their username/password

I think this belongs in ./zcutil instead of making a new ./bin

leto commented 7 years ago

@madbuda sounds good, i can move into zcutil and check for an existing hush.conf. I also need to check for symlinks, right now only a real ~/.hush dir will be found

leto commented 7 years ago

@madbuda would it be more useful to exit 1 if ~/.hush exists, so we can more easily detect that case?

lludlow commented 7 years ago

@leto maybe give them an options if we find an existing config to overwrite it with a warning that it will change user and password.

We should also add a few nodes for them

addnode=us.madmining.club
addnode=183.89.226.141
addnode=163.172.70.26
addnode=76.188.211.191
addnode=173.212.196.148
addnode=78.94.32.197
addnode=77.78.12.89
addnode=78.46.88.113
addnode=163.172.70.26
addnode=192.99.3.29
addnode=144.76.62.229
addnode=163.172.64.208
addnode=37.187.167.145
addnode=[2607:5300:60:341d::1]
addnode=[2001:41d0:d:691::]
addnode=[2a02:c207:2008:8708::1]
addnode=[2001:470:1f09:3b6:7285:c2ff:fe0e:1664]
addnode=[2a02:908:162:67dc:225:90ff:fe50:2b9b]
lludlow commented 7 years ago

@leto thinking some more, why not just make an install script?? instead of run fetch-params.sh, run make-config.sh, run build.sh

we just say clone and run install-hush-$DISTRO.sh

or an install.sh that detects distro, and has the option of building for bitcore as well. each distro has a branch so it makes it less frustrating until we get published releases

leto commented 7 years ago

@madbuda I was building up to that. I would prefer to have another install wrapper that calls this script, and keep this script small + simple, since it is pretty useful by itself.

leto commented 7 years ago

FYI this code needs to handle .hush/ being a symlink before being merged

lludlow commented 6 years ago

Just checking to see if there is a plan to finish this or should we just close it?

jenkins-hush commented 6 years ago

all tests passed

leto commented 6 years ago

Not moving forward with this