search

MyHush / hush

Hush is a fork of Zcash focused on secure communications
https://myhush.org
Other
67 stars 37 forks source link

Change various Zcash references to Hush #32

Closed leto closed 6 years ago

leto commented 7 years ago

@madbuda @radix42 please review, danke

leto commented 7 years ago

This is now in the dev branch, leaving this open

lludlow commented 7 years ago

besides the and and and in clientversion.h it looks good to me, it builds, will test functionality and report back

leto commented 7 years ago

@madbuda thanks for reporting the build status. Nice thing is that now all process names on all platforms will reflect hush* naming pattern, including various threads that have their own names, like hush-loadblk

radix42 commented 7 years ago

There's merged code from upstream of both projects from this year (some cherry picked BTC PR's merged into zcash), so that is actually a legally accurate, if awkward, copyright notice. It's that or have it read as three lines, the "bitcoin developers" one from 2009-2017, the zcash developers one from 2016-2017 and the HUSH Developers for 2017 (or 2016-2017). But it is the mit with notice variant listed in the COPYING file with 4 diff copyright notices and dates is the "most correct".

matthewjamesr commented 7 years ago

I added a commit for proper grammar. @radix42, recommend final review and merge.

radix42 commented 6 years ago

ACK on this after review, can we merge it into the 1.0.12-rc branch tho rather than master to avoid a rebase? thanks!

jenkins-hush commented 6 years ago

all tests passed