search

MyHush / hush

Hush is a fork of Zcash focused on secure communications
https://myhush.org
Other
67 stars 37 forks source link

Updated testnet for ticket "New official Hush testnet #bounty #6" #37

Closed mrhcbojangles closed 7 years ago

mrhcbojangles commented 7 years ago

Updated the testnet parameters to "tush" Generated/mined a new genesis block Added the host info into the block for the origin testnet code currently running at tush.cryptominingpools.org.

Please review.

Thanks,

Tim

tAddress: t1c11VazKq24xJoM55Cp4rpxeM4p6xxmcuR edit madbuda fixes https://github.com/MyHush/hush/issues/6

lludlow commented 7 years ago

fixes https://github.com/MyHush/hush/issues/6

lludlow commented 7 years ago

test this please

jenkins-hush commented 7 years ago

Can one of the admins verify this patch?

jenkins-hush commented 7 years ago

all tests passed

leto commented 7 years ago

:+1: from me

leto commented 7 years ago

@radix42 does this meet your requirements? If so, let's pay out the bounty and get our testnet up so we can play with it!

radix42 commented 7 years ago

can we get a couple/few testnet nodes on it? if so and they can send/receive txns I'll very happily pay out and close this!

On Sun, Oct 8, 2017 at 11:34 PM, Duke Leto notifications@github.com wrote:

@leto approved this pull request.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MyHush/hush/pull/37#pullrequestreview-67895073, or mute the thread https://github.com/notifications/unsubscribe-auth/AF9e0N-LGDQVctCRFE8SuO_a-pdALQNeks5sqb6KgaJpZM4Prgcs .

lludlow commented 7 years ago

We also need to test / cherry pick this into 1.0.12 and verify testnet with that release

leto commented 7 years ago

@madbuda should we merge this into a topic branch off dev so we can more easily run a few nodes with this code, to test it out?

lludlow commented 7 years ago

There is no need, just build from https://github.com/mrhcbojangles/hush

We do need some edits for long term usage, primarily seed nodes

@mrhcbojangles please add testnet.myhush.network in chainparams

lludlow commented 7 years ago

testnet.myhush.network running with cpu miner @leto @radix42 when one of you get a node up let me know so we can add it to chainparams.cpp if permanent. I'll get another testnet node up shortly

hush.conf: addnode=tush.cryptominingpools.org addnode=testnet.myhush.network addnode=testnet.madmining.club equihashsolver=tromp genproclimit=1 testnet=1 gen=1

lludlow commented 7 years ago

not sure if the node listed in this PR is stil live, I am getting crashes generating new blocks hushd: wallet/wallet.cpp:803: void CWallet::DecrementNoteWitnesses(const CBlockIndex*): Assertion `nWitnessCacheSize > 0' failed. Aborted

mrhcbojangles commented 7 years ago

I updated the config on the node to include testnet.myhush.network as well. The block height is currently at 85, so blocks are being generated. I would try to add -reindex and try again.

lludlow commented 7 years ago

Ok, I'll try again when I get home. Is the port open and node running with server=1 ?

lludlow commented 7 years ago

test this please

jenkins-hush commented 7 years ago

all tests passed

mrhcbojangles commented 7 years ago

My config looks like: rpcuser= rpcpassword= rpcport= testnet=1 gen=1 genproclimit=1 server=1 equihashsolver=tromp addnode=testnet.myhush.network

mrhcbojangles commented 7 years ago

I should clarify that I left them blank here, but the username password and port are not blank in the config. Sorry for any confusion.

lludlow commented 7 years ago

what is the p2p port? And is that port open to the world?

mrhcbojangles commented 7 years ago

The p2p port is 18888 (unchanged). It was open to the world. I will reconnect another node to it when I get home to see if I can reproduce what you are seeing.

lludlow commented 7 years ago

@mrhcbojangles I reindexed and let it sync before mining and it looks good so far. I will spin up a few more nodes

mrhcbojangles commented 7 years ago

Awesome. I see that the block count has gone up as well. Let me know if you run into anything else.

lludlow commented 7 years ago

Lets get some confirmations and some tx sent and I will give my 👍🏼 Still need to get a few more nodes up and possibly a testnet explorer if I have time

lludlow commented 7 years ago

https://github.com/madbuda/hush/tree/v1.0.9-win merged in dev and testnet to get a windows client up.

Haven't been able to get a transaction to confirm using linux, dropped new exe's into hush swing wallet to see behavior better

This seems odd to me, blocks are created by a new address every time, will have to wait for blocks to confirm which may take some time hush-testnet

edit Not abnormal, hushd will generate a new address for every block unless you give it mineraddress=

mrhcbojangles commented 7 years ago

I updated my config to include mineraddress=. Is it possible that the node generates an address if one is not specified? This would explain the new addresses. Also, how many confirmations do the transactions have? They will show up immature for a few hours after to obtain the 100 confirmations.

lludlow commented 7 years ago

100 confirmations are needed for a block, you must shield (send from miner address to a z_address) before the coinbase funds can be spent (T to T)

See my edit above, I missed that originally

lludlow commented 7 years ago

test this please

jenkins-hush commented 7 years ago

all tests passed

mrhcbojangles commented 7 years ago

@madbuda Any luck getting the transactions to confirm?

lludlow commented 7 years ago

yes, I have several confirmed tx, TtoZ, TtoT, ZtoZ, ZtoT.

lludlow commented 7 years ago

@radix42 @leto approved, I have done testing and approved as well.

radix42 commented 7 years ago

Awesome, I can pay out bounty in a while this morning

On Oct 12, 2017 6:50 AM, "Larry Ludlow" notifications@github.com wrote:

@radix42 https://github.com/radix42 @leto https://github.com/leto approved, I have done testing and approved as well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MyHush/hush/pull/37#issuecomment-336143031, or mute the thread https://github.com/notifications/unsubscribe-auth/AF9e0MHD5fm4LHkvVAnXCFQ8FnytWyjWks5srhkIgaJpZM4Prgcs .

lludlow commented 7 years ago

ok, I will merge and get a build up and a PR for master

radix42 commented 7 years ago

Bueno, thank you

On Oct 12, 2017 6:52 AM, "Larry Ludlow" notifications@github.com wrote:

ok, I will merge and get a build up and a PR for master

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MyHush/hush/pull/37#issuecomment-336143651, or mute the thread https://github.com/notifications/unsubscribe-auth/AF9e0CO9DM_nHc70pbupg5CNbkXIrbcIks5srhmIgaJpZM4Prgcs .