MyHush / hush

Hush is a fork of Zcash focused on secure communications
https://myhush.org
Other
67 stars 37 forks source link

Latest Zcash Release Merge to v1.0.12-lin #40

Closed oDinZu closed 7 years ago

oDinZu commented 7 years ago

Merged the latest zcash 1.0.12 release into the hush dev codebase 1.0.9

Zcash added IPFS Sprout URL - I left the Zcash IPFS URL. We can change it in future if we want our own URL.

I forked the repo of hush to my repo >> cloned it from my repo >> CD'd to hush >> git checkout v1.0.12-lin >> git branch HushUpgrade >> git checkout HushUpgrade >> git remote add upstream zcash:masterURL >> git pull upstream >> git status >> [Check changed files] >> Modified each file manually to work with Hush >> git add >> git commit -m 'comment' >> git status >> git remote -v >> git remote remove upstream >> git checkout v1.0.12-lin >> git merge >> git push (csharpee/hush.git) >> Create PR

Files Updated: image

The compile has just finished also for a copy of the updated hush files.

lludlow commented 7 years ago

built, node syncing Need to test

@radix42 @leto am I missing anything?

lludlow commented 7 years ago

run tests

jenkins-hush commented 7 years ago

Can one of the admins verify this patch?

lludlow commented 7 years ago

test this please

leto commented 7 years ago

@madbuda how do we tell the difference between "this commit built correctly" versus "this commit built and all tests passed?" I think having both datums posted to Github would be valuable

lludlow commented 7 years ago

@leto look just below, it will show the build status... It is not testing each commit, it is testing the pr. Checkout myhush branch, merge in PR branch, do build

oDinZu commented 7 years ago

Okay, the TX/RX tests have been completed for BalefulStatic:1.0.9 and PickleRick:1.0.12. Each test was sent/received from both versions of hush.git. All tests was completed on Ubuntu 16.04 Linux AWS EC2. The sending address for 1.0.9 was the swing wallet GUI for Windows. The network that was tested on is mainnet.

Types of Tests:

(t,z) (t,t), (z,t) and (z,z) are the 4 xtn types where t=taddr and z=zaddr

History / Links of Each Transaction/Test: T 1.09 to T 1.0.12 (worked sent 3 Hush) https://explorer.myhush.org/tx/282ef5cd56490b4b853620c8310c0901c14d08979887f2e543da4c5e2f7168d0 T 1.09 to Z 1.0.12 (worked sent 3 Hush) https://explorer.myhush.org/tx/5f37a713a1be252d59cc06283faf69f2c563b93a81cf59cfc5e19c2c48b04de3 Z 1.0.9 to Z 1.0.12 (worked sent 1 Hush) https://explorer.myhush.org/tx/f3352c6c8909c4cc85b7c620b888ac105bf8407c87879152e5881689d494f70a T 1.0.12 to Z 1.0.9 (worked sent 2 Hush) https://explorer.myhush.org/tx/201684c2484e1268d9bf4e407a7db28bef698ffead22bb6dbb5718fd6e728a35 T 1.0.12 to T 1.0.9 (worked sent 1 Hush) https://explorer.myhush.org/tx/d34bf2147ae0f5718481adf9cf8b4c952a270a96fc5dc5a0015557d038fcecdf Z 1.0.12 to 1.0.9 (worked sent 1 Hush) https://explorer.myhush.org/tx/a910df624cfdbbd956fd3aae4efdac207a49db3630e75f5020c2984eb260ef64

image

image

image

image

leto commented 7 years ago

@csharpee this is awesome!!! Really nice work. I think this sets the stage for us to document what you did and this will be our QA process for each release, to make sure we have not broken our 4 kinds of xtns

radix42 commented 7 years ago

Also, fixing the test suite will help :-)

lludlow commented 7 years ago

closing, source repo deleted