Hush qa/hush performance-measurements.sh branding for v1.0.12-rc

[oDinZu]

Updated branding /qa/hush/performance-measurements.sh and added .BAK for original file using find and replace perl --Note: After zcash/hush & ZCASH_PID/HUSH_PID changes, I opened the file to check if branding is changed.

I am going to do small edits and create PR's. I can add the BAK to a .ignore if we do not want the backups.

[jenkins-hush]

Can one of the admins verify this patch?

[lludlow]

I am confused with this PR, why are we adding 1.0.9 docs and .bak files?

[oDinZu]

The hush-tx builds now and I updated the branding a bit. I need to update my git config for each user.

The build is running and mining on testnet.

This came in handy https://bitcoin.org/en/release/v0.10.0

[leto]

Also, has the performance script been tested? There are a lot of code changes there.... @csharpee when you are doing "rebranding", try to avoid changing actual code. Just strings/etc that are printed, filenames, etc...

[oDinZu]

The doc changes have been updated.

@leto the ./performance-measurements.sh continues to give me an error on 1.0.9 and also 1.0.12. I can change these files back, but the error message will continue to be the same. I am unsure what this means exactly, it may have something to do with the bash.

Hush 1.0.9 Test of: ./performance-measurements.sh: line 100: $1: unbound variable

Hush 1.0.12 Test of: ./performance-measurements.sh: line 158: $1: unbound variable

Zcash 1.0.12 Test of: ./performance-measurements.sh: line 158: $1: unbound variable

Line 158

case "$1" in
    *)
        case "$2" in
            verifyjoinsplit)
                hushd_start "${@:2}"
                RAWJOINSPLIT=$(hush_rpc zcsamplejoinsplit)
                hushd_stop
        esac
esac

Is the ./performance-measurements.sh ran with another test? All of the /qa/hush needs to be updated to work with hush.

[leto]

@csharpee try giving the program some arguments, $1 means the first argument. I would even call that a bug, the fact that it failed so hard when you don't give it an argument. But that is another story.

[oDinZu]

Hush v1.0.12-rc - With No Changes / Build ./qa/hush/performance-measurements.sh time validatelargetx

./qa/zcash/performance-measurements.sh: line 10: ./src/zcash-cli: No such file or directory ./qa/zcash/performance-measurements.sh: line 77: ./src/zcashd: No such file or directory ./qa/zcash/performance-measurements.sh: line 10: ./src/zcash-cli: No such file or directory ./qa/zcash/performance-measurements.sh: line 10: ./src/zcash-cli: No such file or directory

Hush v1.0.12-rc - Updated each line 10 and 35. ./qa/hush/performance-measurements.sh time validatelargetx

Error reading configuration file: Missing hush.conf
Error reading configuration file: Missing hush.conf
Error reading configuration file: Missing hush.conf

Hush v1.0.12-rc - Updating each (3) zcash.conf.

Error reading configuration file: Missing hush.conf
Error reading configuration file: Missing hush.conf
Error reading configuration file: Missing hush.conf

    ``` rm -rf "$DATADIR"
        mkdir -p "$DATADIR/regtest"
        touch "$DATADIR/zcash.conf" ```

It is creating a zcash.conf on the fly in the $DATADIR and cannot find the hush.conf from hushd. So I change the above to hush.conf. There are only 3 zcash.conf that get created within the functions. I update 1 at a time and test.

    ``` rm -rf "$DATADIR"
        mkdir -p "$DATADIR/regtest"
        touch "$DATADIR/hush.conf" ```

Hush v1.0.12-rc - Error after change zcash.conf to hush.conf

$ ./qa/hush/performance-measurements.sh time validatelargetx

hushd: main.cpp:1553: void InvalidChainFound(CBlockIndex*): Assertion `tip' failed.

I searched zcash github history to see if I could figure out what this error means, but the results were slim. https://github.com/zcash/zcash/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aopen%20assertion%20tip%20

I then checked main.cpp to on line 1553 to see if I could learn what the code was explaining, but this file is over 5000 lines of code.

Zcash 1.0.12 - Test after clean build. $ ./qa/zcash/performance-measurements.sh time validatelargetx

[
  {
    "runningtime": 0.157126
  },
  {
    "runningtime": 0.157831
  },
  {
    "runningtime": 0.157372
  },
  {
    "runningtime": 0.157516
  },
  {
    "runningtime": 0.15756
  }
]

Hush v1.0.9 - With No Changes / Build ./qa/hush/performance-measurements.sh time validatelargetx

Error reading configuration file: Missing hush.conf
Error reading configuration file: Missing hush.conf

I don't know why I even updated this file. Madbuda updated it 8 days ago and I didn't know. I thought I would start with the qa files since I want to learn how to use the testing tools.

https://github.com/MyHush/hush/commit/030ceb26c55d7ddd0ca3899facdfb5e903444a7a#diff-5b3f614bcdc523836f7a3b52780fd61d

[lludlow]

@csharpee with the reset listed above what is this pr for?

[leto]

Let's close this for now, and restart with a new PR @csharpee

[oDinZu]

The PR was to begin with brand changes at first since 'Expand branding' was on the list. So I started with QA folder to begin making name changes. Then after the name changes for performance-measurements, I continued making other edits for the Help2Man for binary files and building the hush-tx. Then I found out after all the time, this file has already been updated.

[lludlow]

That comment was meant as expand on it within the issue, everyone on the team can edit my comment and add items to "expand" on the branding topic so we can get a list of things we wanted to update