Closed lludlow closed 7 years ago
all tests passed
all tests passed
@madbuda I have a small nit and a large nit. The file ci_test.txt
was for debugging, and I think should be removed.
Now the large nit is this:
We are adding a file to the zcutil/
directory, which is NOT a "Zcash Utility", it is a "Hush Utility". I think this is the perfect time to start a hushutil/
directory, for tools which originated from the Hush project.
@radix42 how do you feel about new tools for the Hush project being in the new hushutil/
directory, instead of being added to zcutil/
? I would much prefer to have a new directory, to showcase exactly the differences that Hush project has contributed, and just keep things isolated and compartmentalized.
Other than these 2 nits, I like this merge to master :+1: :+1: :+1:, and we could even move certain scripts to hushutil/
after the merge, whatever works.
ACK and I'm gonna push the merge button...thanks guys, this is a ton of work!
merge changes from dev into master
@radix42 see https://build.madbuda.me/job/hush-dev-nightly/ for latest build I've been running dev few a few days now and have not ran into any issues.