Closed oDinZu closed 6 years ago
Can one of the admins verify this patch?
did this stuff get merged outside of this pull request into 1.0.12?
No. This was initially before the 1.0.12 release, then I recreated the PR again after some failed attempts -- I can redo the changes. After the hush team merge from 1.0.9 to 1.0.12 master, my repo of hush was entirely different and a merge was going to be more work than redoing the above changes.
yeah that's a rebase situation, and rebase is not my personal strong suit with git :-) but rebasing this PR on top of master would be what I think we "should" do....or its spiritual equivalent by other means
On Fri, Nov 3, 2017 at 7:56 PM, Charles B. Sharpe notifications@github.com wrote:
No. This was initially before the 1.0.12 release, then I recreated the PR again after some failed attempts -- I can redo the changes. After the hush team merge from 1.0.9 to master, my repo of hush was entirely different and a merge was going to be more work than redoing the above changes.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MyHush/hush/pull/58#issuecomment-341867172, or mute the thread https://github.com/notifications/unsubscribe-auth/AF9e0EuDm96YnLYCzRX8FBMxXKhIuiSrks5sy9JlgaJpZM4P7bAZ .
Okay,
The updated PR is linked here @radix42:
https://github.com/csharpee/hush/tree/hush-tx https://github.com/csharpee/hush/tree/hush-help
I am still learning myself with Git. I enjoy the complexities of git, I wish it was more intuitive though.
The following holds true for the initial update + I added hush-tx support for zcutil/build-debian-package.sh. Each branch was tested and compiled and ran on testnet and mainet before commenting.
Let me know when or if I need to update anything further.
I tested the version for all the help2man pages. The only problem with using -f is it forced it which resulted in .dirty and errors, but still populated the hush-tx manual. The help file works, but the -version does not.
After the tests, I built via build.sh and ./src/hushd -testnet The node is mining and running now.