MyHush / hush

Hush is a fork of Zcash focused on secure communications
https://myhush.org
Other
67 stars 37 forks source link

Deterministic Builds #65

Closed kentsommer closed 6 years ago

kentsommer commented 6 years ago

Remaining work / notes:

  1. This PR includes my public key which I was using for testing. This key should be replaced (and removed from the repo) with core developer GPG keys.

  2. There are a few TODO: sections left in MyHush/hush-gitian.

  3. Finally, the hush_version tag (currently pointing to 1.0.12-dev) should point to 1.0.12. However, before that happens, the 1.0.12 release needs to be updated to include these PR'ed changes.

If I am given a list of GPG keys I am happy to PR the required changes listed in item 1. I can also PR the changes in 2 if you would like but it is probably just faster for one of you to update them quick.

t1JjmKWun4jn61JgVSK1fQKifVToqhKsov3

jenkins-hush commented 6 years ago

Can one of the admins verify this patch?

lludlow commented 6 years ago

test this please

jenkins-hush commented 6 years ago

all tests passed

kentsommer commented 6 years ago

:LGTM:

@radix42 Can I merge this in? I will update the required references mentioned in the PR after this is merged.

kentsommer commented 6 years ago

This is merged by https://github.com/MyHush/hush/pull/68

I'll make the necessary changes listed in this PR and then close this out.

kentsommer commented 6 years ago

Apart from the version tag that is necessary, this is all updated and fixed. Once the commits are on master everything will work :+1:

I'm closing this out.