MyHush / hush

Hush is a fork of Zcash focused on secure communications
https://myhush.org
Other
67 stars 37 forks source link

z_embedstring and z_readstring #66

Open leto opened 6 years ago

leto commented 6 years ago

This adds 2 RPC methods which are useful for injecting and reading from memo fields

Bounty

25 HUSH for passing tests for both RPCs added in this PR

Start to manually merge https://github.com/zcash/zcash/pull/2606

jenkins-hush commented 6 years ago

all tests passed

kentsommer commented 6 years ago

ack, :LGTM: @leto

jenkins-hush commented 6 years ago

all tests passed

leto commented 6 years ago

This needs tests before being merged to dev

kentsommer commented 6 years ago

Running any RPC tests as well as adding these new ones and testing them will require generating a new Regtest genesis block.

leto commented 6 years ago

@kentsommer a long time ago you pointed me at some repos where we could generate a valid regtest block and some explanation, would you mind sharing those again?

leto commented 6 years ago

Created https://github.com/MyHush/hush/issues/100 to track regtest genblock