search

MyHush / hush3

Hush: Speak And Transact Freely
https://myhush.org
Other
15 stars 13 forks source link

GetSaplingNoteWitnesses coredump #115

Closed leto closed 4 years ago

leto commented 4 years ago 
 komodod: wallet/wallet.cpp:2147: void CWallet::GetSaplingNoteWitnesses(std::vector<SaplingOutPoint>, std::vector<boost::optional<libzcash::IncrementalWitness<32, libzcash::PedersenHash> > >&, uint256&): Assertion `*rt == witnesses[i]->root()' failed.
./src/hushd: line 75: 17779 Aborted                 (core dumped) $KMD -ac_name=$NAME -ac_sapling=$SAPLING -ac_reward=$REWARD -ac_halving=$HALVING -ac_end=$END -ac_eras=$ERAS -ac_blocktime=$BLOCKTIME -ac_cc=2 -ac_ccenable=$CCENABLE -ac_founders=$FOUNDERS -ac_supply=$SUPPLY -ac_perc=$PERC -clientname=$CLIENTNAME -addnode=$NODE1 -addnode=$NODE2 -addnode=$NODE3 -addnode=$NODE4 -ac_cclib=$CCLIB -ac_script=$SCRIPT "$@"

on commit ff0ce2b69a16bf2fa7c39bf2bafec0a2199c53d6 of danger branch

leto commented 4 years ago

related to https://github.com/MyHush/hush3/issues/119

leto commented 4 years ago

I refactored the code to no longer coredump, and now it ignores the issue with == not working correctly. Printing the data (stringifying it) shows that they are the same. It might be a typecasting issue, where we need to cast stuff to a string and then compare

leto commented 4 years ago

Covered in #119