search

MyHush / hush3

Hush: Speak And Transact Freely
https://myhush.org
Other
15 stars 13 forks source link

Incorrect "CWallet::GetSaplingNoteWitnesses: Invalid witness root!" exception #119

Open leto opened 4 years ago

leto commented 4 years ago

this is from CWallet::GetSaplingNoteWitnesses in src/wallet/wallet.cpp .

It seems that removing some Sprout code has messed up the == operator for SaplingNotes, so we currently just print to STDERR instead of throwing a logic_error. Upstream ZEC will coredump at run-time with an assert.

This should be fixed correctly so this line of code works as intended:

1732                if(*rt == witnesses[i]->root()) {