Closed miodragpop closed 4 years ago
@miodragpop please delete Proton completely from Hush as part of your PR, which should simplify it
@miodragpop if you have some unnecessary whitespace changes (which I think I see in various places), I prefer not to see those, unless it's fixing some bad formatting. If so, whitespace changes should be made in their own commit and not mixed with functional changes, going forward
@ssadler some of this PR changes the CC build system, that looks like it should be sent to KMD. I was wondering if you could code review and give comments about sending it upstream
@ssadler some of this PR changes the CC build system, that looks like it should be sent to KMD. I was wondering if you could code review and give comments about sending it upstream
Hi, it appears to alter the CC build system but in practice it does not; secp256k1 inside the cryptoconditions tree is not part of the cryptoconditions/libcryptoconditions_core.la
build target used by komodo.
The change made to the secp256k1 target removes the -march
parameter which was added for verus in https://github.com/jl777/komodo/commit/f2c103207f5137029bffd2c948d202498433eb89, but build configs aren't my specialty and I have no idea why! I think improvements for building on ARM will be welcome upstream though.
build script for aarch64 deleted ... cross build is available via default build.sh as in HOST=aarch64-linux-gnu zcutil/build.sh
@miodragpop that is a huge improvement! Impressive
cross-build process is still several times faster than native build on Raspberry Pi 4 ...
sudo apt-get install gcc-aarch64-linux-gnu g++-aarch64-linux-gnu
zcutil/build-cross-aarch64.sh -j$(nproc)