MyHush / hush3

Hush: Speak And Transact Freely
https://myhush.org
Other
15 stars 13 forks source link

Send PR to Bisq to add Hush #22

Closed leto closed 4 years ago

leto commented 5 years ago

https://docs.bisq.network/exchange/howto/list-asset.html

500 HUSH bounty for somebody to write the necessary code and send PR

oDinZu commented 4 years ago

There are no address validation examples for a KMD smartchain via Bisq. I used Zcash as a model, although I do not think this will work since we do not use the"t"at the beginning of Hush3 addrs.

For this reason, I begun reading KMD / Hush3 code to figure out how the address is created and validated. Would you or others know the hierarchy of how the process flows?

As an example: ./src/hush-cli getnewaddress

The command invokes hush-cli file, then that file invokes komodo-cli to retrieve a new address...please correct me if I am wrong.

On opening of komodo-cli, the file encoding is not supported, reason I am asking the question here.

In conclusion, the only thing we need to verify is these lines of Java code:

    public Hush() {
        super("Hush", "HUSH", new RegexAddressValidator("^t.*", "validation.altcoin.zAddressesNotSupported"));
    }

}

You can see what we have so far: https://github.com/csharpee/bisq/commit/dca145b6ba76ce81b0656f6802e01a67ce33dad2

leto commented 4 years ago

@csharpee unless Bisq can support zaddrs, working on this is not useful, as we will be removing taddr support soon.

oDinZu commented 4 years ago

Okay, they do not support z-addrs.