MyHush / hush3

Hush: Speak And Transact Freely
https://myhush.org
Other
15 stars 13 forks source link

Libsodium 1.0.15 is old and unsupported #44

Closed leto closed 4 years ago

leto commented 4 years ago

libsodium just moved the URL of the binary we download, breaking our build system and most likely almost all Zcash coin build systems.

--- a/depends/packages/libsodium.mk
+++ b/depends/packages/libsodium.mk
@@ -1,6 +1,6 @@
 package=libsodium
 $(package)_version=1.0.15
-$(package)_download_path=https://download.libsodium.org/libsodium/releases/old
+$(package)_download_path=https://download.libsodium.org/libsodium/releases/old/unsupported
cipig commented 4 years ago

komodod builds fine with libsodium 1.0.18 https://github.com/KomodoPlatform/komodo/commit/5bb0bdffac7331e41baa40b563d342071df69110

leto commented 4 years ago

@cipig that is really good to know, but it seems like we should put a libsodium version upgrade thru more testing. I agree that we want to update to 1.0.18 long term. I made this PR before I saw this comment:

https://github.com/jl777/komodo/pull/1763

@jl777 do you have a preference?

leto commented 4 years ago

After looking at the release notes, it looks low-risk to upgrade and there seems to be many performance improvements. I have upgraded to 1.0.18 on the duke branch. Thanks again @cipig