search

MyHush / hush3

Hush: Speak And Transact Freely
https://myhush.org
Other
15 stars 13 forks source link

getchaintxstats incorrectly counts some transactions #82

Open leto opened 4 years ago

leto commented 4 years ago

We assume there is 1 coinbase output per block in our algorithm, but Hush actually has 2, one for the miner and one for the FR output. This means that our "organic" stats are incorrect, which delete the count of coinbase from stats and assumes 1 per block.

leto commented 4 years ago

Also, the first 128 blocks of Hush v3 mainnet had no block reward or FR, and so had 0 coinbase outputs. This is low priority to fix but would be nice.

leto commented 4 years ago

The code should also take into account -ac_end, when BR ends, for completeness.

leto commented 4 years ago

We now correctly count 2 coinbase per block.