search

MyHush / hush3

Hush: Speak And Transact Freely
https://myhush.org
Other
15 stars 13 forks source link

ThreadNotifyWallets upstream bug #87

Closed leto closed 4 years ago

leto commented 4 years ago

Research if this upstream bug affects us:

https://github.com/zcash/zcash/pull/4379

https://github.com/zcash/zcash/issues/4301

daira commented 4 years ago

This problem was introduced in https://github.com/zcash/zcash/pull/4252. We do recommend that you take that PR if you haven't already done so, as well as the fix in https://github.com/zcash/zcash/pull/4379.

leto commented 4 years ago

@DenioD do you have all your latest code on Github? I have some time to help you with this now, we should try to get this into the 3.3.2 release if we can

zancas commented 4 years ago

@leto note that #4379 introduced a race condition that is fixed in #4390 according to the associated commit messages.

leto commented 4 years ago

We have merged this code into our dev branch and made a new issue to track zcash#4390, thanks to @zancas for the heads up :+1: