search

MyHush / hush3

Hush: Speak And Transact Freely
https://myhush.org
Other
15 stars 13 forks source link

Untested sapling consolidation plus sietch outputs to reduce metadata leakage #94

Closed leto closed 4 years ago

leto commented 4 years ago

@DenioD can you give this a test? If you do, post an explorer link here for a sapcon tx it makes.

We should see all sapcon ztx's created with this code have exactly 8 zouts, which blends in currently with the most common number of zouts z_sendmany creates for average ztxs.

Additionally, this code reduces anonset reduction by 7 per transaction and obscures the amounts going to any one zout.

DenioD commented 4 years ago

@leto Test was successfully. https://explorer.myhush.org/tx/39464d53a3740a0e7f307046e170a6fa51f153c22e5171d4d14688139902b55d

leto commented 4 years ago

@DenioD super awesome! I see that tx has a fee=0, did that happen by itself or did you manually set it to fee=0?

DenioD commented 4 years ago

@leto the fee is set to 0 here https://github.com/MyHush/hush3/blob/sapcon_sietch/src/wallet/asyncrpcoperation_saplingconsolidation.h#L8

DenioD commented 4 years ago

@leto i think its better to use our default fee, to reduce Metadata

leto commented 4 years ago

This PR nows sets the fee to be the default, which makes consolidation tx's harder to identify and a maximum number of zutxos to consolidation of 8.