search

MyIntervals / emogrifier

Converts CSS styles into inline style attributes in your HTML code.
https://www.myintervals.com/emogrifier.php
MIT License
905 stars 153 forks source link

[TASK] Update the CI tools #1227

Closed oliverklee closed 12 months ago

oliverklee commented 12 months ago

Also update the configuration files.

oliverklee commented 12 months ago

I am curious to know why our CI/weekly build seems to keep using the minimum version of the PHIVE Phars, rather than the latest that satisfy the version constraint.

That's because phive install (which we're using in the CI pipeline) installs the exact version configured as installed in the phars.xml, while phive update <package> would install the highest version allowed by version:

<phar name="php-cs-fixer" version="^3.13.0" installed="3.13.0" location="./.phive/php-cs-fixer" copy="false"/>

phive update will also update the installed version in the phars.xml, but leave the version alone.

(I usually update both when updating our CI tools.)

oliverklee commented 12 months ago

Ah, it looks like I missed to read part of your comment, @JakeQZ. Sorry for that.

I'd prefer use to have pinned versions for our CI tools: I don't want our CI build to fail if we haven't changed anything (and it's not due to an update to a production dependency).

oliverklee commented 12 months ago

Wasn't immediately obvious to me that the values should be in an array with the keys 'elements' and 'space'.

It wasn't to me, either. ;-)