search

MyIntervals / emogrifier

Converts CSS styles into inline style attributes in your HTML code.
https://www.myintervals.com/emogrifier.php
MIT License
905 stars 153 forks source link

[FEATURE] Support preserving !important #1237

Closed penn5 closed 11 months ago

penn5 commented 11 months ago

I don't think I have time to learn whatever test framework you use, sorry. Please unassign me

oliverklee commented 11 months ago

I don't think I have time to learn whatever test framework you use, sorry.

That's a pity to hear. :-(

Unless someone takes the time to write the necessary tests for this feature, I fear it won't get merged. (We don't really do regular manual testing of this library. So we require bug fixes and new features to be covered by tests so we can be sure that later changes to the code don't break existing functionality.)

oliverklee commented 11 months ago

@penn5 If you want help/support for running and writing the tests, please let us know. We're willing to help.

penn5 commented 11 months ago

Unfortunately I don't know anything about php unit testing and I don't really have time to learn. Sorry.

oliverklee commented 11 months ago

Closing then. If at any time you would like to give the tests a go, please feel free to reopen this PR. We'll be happy to support you with the tests.