search

MyIntervals / emogrifier

Converts CSS styles into inline style attributes in your HTML code.
https://www.myintervals.com/emogrifier.php
MIT License
907 stars 154 forks source link

Drop support for unsupported Symfony versions #1242

Open oliverklee opened 10 months ago

oliverklee commented 10 months ago

https://symfony.com/releases

JakeQZ commented 10 months ago

I don't think we should do this until we need to, e.g. because we need a new feature or bugfix.

I made a similar argument against dropping support for 'unsupported' PHP versions until we have to. This was discussed in #1206. In #1207 you tried to re-established support for PHP 7.2, but we found we did actually need to ditch it after all.

Main point is that it's not for us to force users to upgrade third party components if there are no known compatibility issues with the older versions. We've thoroughly tested against these older versions, through each iteration or both our software and theirs, which is more than can be said for the latest version of a third-party component.

'Unsupported' does not mean 'broken'. It just means that the developers have chosen to save resources by not merging any more bug fixes to a previous release branch - which is understandable: as the code deviates, such merges become more and more time-consuming and error-prone.

I've had situations where Composer cannot satisfy dependencies due to chains of minimum and maximum version dependencies leading to one component needing a later version of a dependency than the latest allowed by some other component. I'd rather avoid inflicting that problem on our users unnecessarily.

On that basis, I'm moving this to a future milestone.

JakeQZ commented 10 months ago

Also worth noting that some developers do apply security vulnerability fixes to unsupported versions. E.g. WordPress released 4.1.39 on 12 October 2023, almost 9 years after the initial 4.1 release. They don't use semver, so the latest 6.4 is 23 major releases ahead. The latest PHP version supported by WordPress 4.1.39 is PHP 5.6.