[CLEANUP] Reorder methods in PregTest

MyIntervals / emogrifier

Converts CSS styles into inline style attributes in your HTML code.

https://www.myintervals.com/emogrifier.php

MIT License

911 stars 154 forks source link

[CLEANUP] Reorder methods in PregTest #1327

Closed JakeQZ closed 2 months ago

JakeQZ commented 2 months ago

They are now grouped by the method tested, apart from tests for the exception switch, which cover all methods at once.

coveralls commented 2 months ago

coverage: 97.0%. remained the same when pulling 15094afa61b3b7930eee0406770ec7460797353d on cleanup/preg-test-reorder into 201fda8e71de15d5201dc3287eeddedb4c6de94c on main.

JakeQZ commented 2 months ago

@oliverklee, I recall a discussion about method ordering (though not where on when), in which we kind-of agreed:

Methods should be grouped by functionality, regardless of whether they are private or public;
Supporting methods (such as data providers and callbacks, in this case) should be presented before the higher-level method that uses them.

I've followed that principle here.