MyIntervals / emogrifier

Converts CSS styles into inline style attributes in your HTML code.
https://www.myintervals.com/emogrifier.php
MIT License
908 stars 154 forks source link

Mark the utitlity classes as @internal? #713

Closed oliverklee closed 5 years ago

oliverklee commented 5 years ago

Hi @zoliszabo, @JakeQZ, should we mark the utility classes (CssConcatenator and ArrayIntersector) as @internal so it is clear that they might be removed, moved around or have their API changed without prior notice?

JakeQZ commented 5 years ago

This also occurred to me.

Though now #712 is committed, I don't envisage much likelyhood of that happening - they fulfill the purpose for which they were intended - even #668 is unlikely to have an impact.

OTOH, if there were to be a breaking change it would avoid the need for a new major version. And anyone using them is likely to be fairly clued up and judicious about potentially breaking updates and take heed of such a notice - it doesn't prevent them being used.