PortScanner() launch the scan() with an automatic "-oX -" arguments

MyKings / python-masscan

python-masscan is a python library which helps in using masscan port scanner.

https://pypi.org/project/python-masscan/

GNU General Public License v3.0

281 stars 60 forks source link

PortScanner() launch the scan() with an automatic "-oX -" arguments #12

Closed dplastico closed 5 years ago

dplastico commented 5 years ago

Hello,

When executing a scan() the arguments "-oX" and a "-" are hardcoded and passed to the scan with also the "argumets=" I would think is better to not have this hardcoded since I do not want to have all my scans being exported also the "-" generates issues when passing custom arguments

I fixed this deleting the arguments in line 269 of masscan.py Before: After:

I don't know how to report this things (1st time in github) so sorry if this was no the proper way to report it

Edit: typo Renato.

MyKings commented 5 years ago

Hi, @dplastico

args = [self._masscan_path, '-oX', '-']  ...

The -oX here means to save the masscan scan results in xml file format.
- means that the stdout result of masscan -oX is taken as stdin , so that no file is generated and the scan result is taken, so it cannot be deleted here.

Finally, thank you for your support of python-masscan.