MyKings / python-masscan

python-masscan is a python library which helps in using masscan port scanner.
https://pypi.org/project/python-masscan/
GNU General Public License v3.0
281 stars 60 forks source link

Remove shebang #18

Closed fabaff closed 5 years ago

fabaff commented 5 years ago

python-masscan is imported to use, thus there is no need for shebangs.

Otherwise the shebangs need to be removed during the build process of the package.

sed -i -e '/^#!\//, 1d' masscan/*.py

Related to #17

MyKings commented 5 years ago

Hi bro,

I think this pr needs to be carefully considered, and there may be several reasons for this:

So, this pr can't be merged for a while, I need to test it for a while. We can also consider not supporting py2.6/2.7, of course I don't think this is a good idea, or we will remove support for py2.6/2.7 after 2020 :)

Thank you very much for the code provided to python-masscan. Good wishes.

fabaff commented 5 years ago

If Python 2.x support should stay then this PR should not be merged in its current state.

fabaff commented 5 years ago

It's no only the shebang and the docstring.