search

MyLife-Services / mylife-maht

MyLife Member Services Repository
https://humanremembranceproject.org
MIT License
1 stars 1 forks source link

Personal Avatar name change doesn't take fully #322

Closed Whammo22 closed 2 weeks ago

Whammo22 commented 3 months ago

Upon entering a new Avatar name it is updated in the header but then the text box reverts to the default. The chatbot window isn't updated.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'My Life'
  2. Click on 'Arrow' to expand the Avatar Section
  3. Click in my personal-avatar box and update the name
  4. Observe the header will display the new name
  5. Change bots to Biographer or Scrapbook
  6. Revert to Avatar bot. The Chatbot window still displays the default My personal-avatar name
  7. Bot Name textbox name is reverted to My personal-avatar

Expected behavior Bot name will be updated across chatbot and bot windows upon updating them.

Screenshots

Image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

Whammo22 commented 2 months ago

Screenshot_20240819-181537 Just tried new username and got this error.

Whammo22 commented 2 months ago

@Mookse Happens on Desktop as well.

Mookse commented 2 months ago

Gack - I think this might be a ghost in your account, as I can't replicate it on either my real or test account. @Whammo22 I'm pretty convinced this is related to renaming your member-id, we can use this ticket for non-secure info, I'll push this to this weekend's 0.18, see if I can see where the data is disconnecting

Whammo22 commented 2 months ago

I get the 🪲 badge 🏆. While I see this is an edge case we may need to consider if this could resurface and what the impact would be if similar request was made from a user. I know the drop-down is going away eventually but changing username might be a thing.

Mookse commented 1 month ago

@Whammo22 Great work on this one - I hate to say that I forgot exactly where we left it - I think we conquered the first part when we removed your ghost avatar, and the second is this lingering problem I'm going to look at today, which is about frontend session connection management. If this isn't a consistent error, i.e., if you try again and it doesn't break, we can close this

Whammo22 commented 2 weeks ago

Sorry I forgot to retest my I'll try it.

On Sat, Sep 28, 2024, 12:41 PM Erik Jespersen @.***> wrote:

@Whammo22 https://github.com/Whammo22 Great work on this one - I hate to say that I forgot exactly where we left it - I think we conquered the first part when we removed your ghost avatar, and the second is this lingering problem I'm going to look at today, which is about frontend session connection management. If this isn't a consistent error, i.e., if you try again and it doesn't break, we can close this

— Reply to this email directly, view it on GitHub https://github.com/MyLife-Services/mylife-maht/issues/322#issuecomment-2380844876, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJUSSQXE262XSE4MSJHVTEDZY3S5RAVCNFSM6AAAAABL5ENNYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBQHA2DIOBXGY . You are receiving this because you were mentioned.Message ID: @.***>