search

MyOnlineStore / omnipay-klarna-checkout

Klarna Checkout gateway for Omnipay
MIT License
13 stars 12 forks source link

[Question] Deviations from Omnipay API #76

Open jesperbjerke opened 3 years ago

jesperbjerke commented 3 years ago

I might just be a bit confused, but it looks like this package is not conforming to the abstractions of Omnipay, and instead is using the direct implementations of the payment provider. Is there a specific reason to do so? Any plans to align it more with Omnipay? I mean, using Omnipay kind of looses its point if there are a bunch of custom methods/implementations for each provider anyways.

Some examples can be found in this issue https://github.com/MyOnlineStore/omnipay-klarna-checkout/issues/69 And also looking at how the options are expected in this package compared to https://omnipay.thephpleague.com/api/cards/

DanPigment commented 3 years ago

I'm also experiencing issues with conformity to Omnipay standards. I'm implementing a shop in Aimeos which is a Laravel extension, they have full support for Omnipay, but this extension does not work without overriding their Omnipay Provider class, in part due to different namespaces than expected. For example they expect to be able to initialise via Omnipay\Omnipay::create( 'KlarnaCheckout' ); but that does not work.

chrillep commented 2 years ago

ping @fred-jan @frankverhoeven