MyPetORG / MyPet

🐕 Extensive pet plugin for Bukkit/Spigot
https://www.spigotmc.org/resources/mypet.12725/
GNU Lesser General Public License v3.0
177 stars 96 forks source link

Multiple pets (Feature Request) #186

Closed TomaatHoeky closed 10 years ago

TomaatHoeky commented 10 years ago

Dear Keyle,

Could you add multiple mypets to MyPet so players can have multiple pets and if possible a permissions like : Mypet.Pets.2 (for 2 pets) Mypet.Pets.3 (for 3 pets) etc.

If this can be added, it would be great!

Regards, Tomaat

zerafox commented 10 years ago

Keyle has already said he will not make it possible to have multiple pets with a player at a time... If you want players to have multipets (option of 1 out at a time) install MyPet NPC...

triarry commented 10 years ago

Yeah, I like what he did with MyPet NPC, but I still hope in the future there will be a way to select an "active" MyPet, and all pet commands will be used on that active pet. Otherwise, all other pets you own will be "inactive". And you could activate them by name or what have you. A dream, but maybe MyPet NPC will have this in the future.

zerafox commented 10 years ago

This was suggested once before too, that's why I think Keyle made the NPC... Don't expect this to pass and get added. It's not that hard to walk to the NPC and just exchange your pets...

TomaatHoeky commented 10 years ago

ah okay thanks, i didnt know there was a mypet npc :) i added it (citizens + mypet npc) and created a Villager with the trait mypet-storage , how to open the storage? i cant access it :/

scomans commented 10 years ago

You just need to rightclickt the NPC. If you have a MyPet it will ask you to store, if you don't have a MyPet and already stored at least one it will show you a selection of your stored pets.

scomans commented 10 years ago

As @zerafox said I will never allow more than one pet. It would be possible and it would be no problem for me to implement this but I just don't want it.

TomaatHoeky commented 10 years ago

ahm. i want to create a NPC with the name Tomaat i execute this command : /npc create Tomaat --trait pet-storage

it now says you created Tomaat with traits .

scomans commented 10 years ago

/npc create Tomaat --trait mypet-storage

TomaatHoeky commented 10 years ago

I did that, it now said Created Tomaat with Trait mypet-storage , but it doesnt work, when i right click the NPC it wont show any gui (do i need spout ?) I have my pet with me (do i need to despawn it ?)

or do i need your pet egg plugin ?

scomans commented 10 years ago

Do you have the permissions to do that?

No the egg plugin has nothing to do with anything

zerafox commented 10 years ago

You do not need the egg plugin, that is just different option to store the pets, though I don't think it's currently working/doing anything.

You do not need spout to show the NPC's GUI, as it is just a version of the chest's GUI. Are you using the NPC as an OP or as a player? Because you will need to give permissions to use the NPC properly.

TomaatHoeky commented 10 years ago

I tested the plugin on both OP and Player, i right click the npc while holding nothing in my hand and my pet next to me

zerafox commented 10 years ago

I'd double check to make sure the trait stuck to him. Select the NPC.. /npc select tomaat

Then do this: /trait mypet-storage

And try again.

TomaatHoeky commented 10 years ago

Still wont work, i did the command /npc create Tomaat --trait mypet-storage /npc select 0 (its id) /trait mypet-storage trait mypet-storage removed i did /trait mypet-storage again trait mypet-storage added

and i right click, still wont work

zerafox commented 10 years ago

If the permissions for player's to use the storage aren't in your permissions plugin file, it won't work...

If your Citizens, MyPet or MyPet NPC are outdated, it won't work... Check to make sure all these are updated and your permissions are applied for the players you want to use this plugin. It works, I know it does. I use it without any problems.

If it's erroring, it would show a log in console. If there is a log in console, post it here when you try to use it. If everything is up-to-date, and you're doing the commands to create it properly, there shouldn't be an issue though... Something is wrong somewhere, and we need more information...

TomaatHoeky commented 10 years ago

hmm i just freshly downloaded the new 1.1.4 of Mypet, freshly downloaded Mypet NPC and Citizens aswell Mypet version : 1.1.4 Mypet-NPC version 0.0.1 Citizens version 2.0.9-SNAPSHOT

Im trying to use them as OP , with '*' perms and im trying as player with the real perms of mypet npc too

zerafox commented 10 years ago

Well depending on what perm plugin you're using, the * may not work... XD

Also, build #'s help too...

We do know that if you're able to set the trait from MyPet NPC that the NPC itself is working... If it wasn't, the trait would be unrecognized by Citizens...

Again, you get nothing in chat when you try to use the NPC or in console?

Do you also have a pet on you (summoned or dismissed doesn't matter)

TomaatHoeky commented 10 years ago

I am getting an error : 21:05:48 CONSOLE: [SEVERE] Could not pass event NPCRightClickEvent to Citizens v2.0.9-SNAPSHOT (build 966) 21:05:48 CONSOLE: java.lang.NoSuchMethodError: de.Keyle.MyPet.util.WorldGroup.getGroup(Ljava/lang/String;)Lde/Keyle/MyPet/util/WorldGroup; 21:05:48 CONSOLE: [SEVERE] Could not pass event NPCRightClickEvent to Citizens v2.0.9-SNAPSHOT (build 966) 21:05:48 CONSOLE: java.lang.NoSuchMethodError: de.Keyle.MyPet.util.WorldGroup.getGroup(Ljava/lang/String;)Lde/Keyle/MyPet/util/WorldGroup; 21:05:48 Co-Owner: Kota : forlike .50$ 21:05:50 CONSOLE: [SEVERE] Could not pass event NPCRightClickEvent to Citizens v2.0.9-SNAPSHOT (build 966) 21:05:50 CONSOLE: java.lang.NoSuchMethodError: de.Keyle.MyPet.util.WorldGroup.getGroup(Ljava/lang/String;)Lde/Keyle/MyPet/util/WorldGroup; 21:05:50 CONSOLE: [SEVERE] Could not pass event NPCRightClickEvent to Citizens v2.0.9-SNAPSHOT (build 966) 21:05:50 CONSOLE: java.lang.NoSuchMethodError: de.Keyle.MyPet.util.WorldGroup.getGroup(Ljava/lang/String;)Lde/Keyle/MyPet/util/WorldGroup; 21:05:50 CONSOLE: [SEVERE] Could not pass event NPCRightClickEvent to Citizens v2.0.9-SNAPSHOT (build 966) 21:05:50 CONSOLE: java.lang.NoSuchMethodError: de.Keyle.MyPet.util.WorldGroup.getGroup(Ljava/lang/String;)Lde/Keyle/MyPet/util/WorldGroup; 21:05:50 CONSOLE: [SEVERE] Could not pass event NPCRightClickEvent to Citizens v2.0.9-SNAPSHOT (build 966) 21:05:50 CONSOLE: java.lang.NoSuchMethodError: de.Keyle.MyPet.util.WorldGroup.getGroup(Ljava/lang/String;)Lde/Keyle/MyPet/util/WorldGroup; 21:05:50 CONSOLE: [SEVERE] Could not pass event NPCRightClickEvent to Citizens v2.0.9-SNAPSHOT (build 966) 21:05:50 CONSOLE: java.lang.NoSuchMethodError: de.Keyle.MyPet.util.WorldGroup.getGroup(Ljava/lang/String;)Lde/Keyle/MyPet/util/WorldGroup;

(think i right clicked 3-4 times)

Lets replace citizens! :D

zerafox commented 10 years ago

Looks like your Citizens is outdated... Try updating it.

scomans commented 10 years ago

No this has nothing to do with an outdated Citizens ;)

TomaatHoeky commented 10 years ago

yup dev build of Citizens : 21:10:43 CONSOLE: [SEVERE] Could not pass event NPCRightClickEvent to Citizens v2.0.9-SNAPSHOT (build 972) 21:10:43 CONSOLE: java.lang.NoSuchMethodError: de.Keyle.MyPet.util.WorldGroup.getGroup(Ljava/lang/String;)Lde/Keyle/MyPet/util/WorldGroup; 21:10:43 CONSOLE: [SEVERE] Could not pass event NPCRightClickEvent to Citizens v2.0.9-SNAPSHOT (build 972) 21:10:43 CONSOLE: java.lang.NoSuchMethodError: de.Keyle.MyPet.util.WorldGroup.getGroup(Ljava/lang/String;)Lde/Keyle/MyPet/util/WorldGroup; 21:10:43 CONSOLE: [SEVERE] Could not pass event NPCRightClickEvent to Citizens v2.0.9-SNAPSHOT (build 972) 21:10:43 CONSOLE: java.lang.NoSuchMethodError: de.Keyle.MyPet.util.WorldGroup.getGroup(Ljava/lang/String;)Lde/Keyle/MyPet/util/WorldGroup;

What could it be?

zerafox commented 10 years ago

I guess I missed this part:

21:05:50 CONSOLE: java.lang.NoSuchMethodError: de.Keyle.MyPet.util.WorldGroup.getGroup(Ljava/lang/String;)Lde/Keyle/MyPet/util/WorldGroup;

TomaatHoeky commented 10 years ago

think so, i wanna know what it is D: i really want it fixed

zerafox commented 10 years ago

Could it be that the build of MyPet you're using isn't working the build of MyPet NPC you're using? I'm really terrible at these error logs so I can only guess really...

TomaatHoeky commented 10 years ago

hmm that could be true, what versions do you use ?

zerafox commented 10 years ago

MyPet #429 (upgrading to #432 now) MyPet NPC # 43 Citizens #972

TomaatHoeky commented 10 years ago

could you upload those versions (the jars) into a zip file ? that would be awesome :)

zerafox commented 10 years ago

But they are easily downloadable from the Dev release location of each plugin..

TomaatHoeky commented 10 years ago

hmm ill search for them

scomans commented 10 years ago

http://build.keyle.de/job/MyPet/ http://build.keyle.de/job/MyPet-NPC/ http://citizens.playat.ch:8080/job/Citizens2/

TomaatHoeky commented 10 years ago

Fixed! Thanks!