Refactor/devtooling 395

[sureshperiyappan]

Package refactoring done for architect_schedules package.

[dginty4]

@sureshperiyappan just a quick note when creating PRs, make sure to have the dev branch as the destination instead of main

[sureshperiyappan]

@sureshperiyappan just a quick note when creating PRs, make sure to have the dev branch as the destination instead of main

@dginty4 , In that case let me close this PR and recreate new.

[charliecon]

@sureshperiyappan just a quick note when creating PRs, make sure to have the dev branch as the destination instead of main

@dginty4 , In that case let me close this PR and recreate new.

No need to do that. It looks like Declan changed the target branch. This PR is perfectly fine

[dginty4]

@sureshperiyappan I also just ran the tests there, you need to register "genesyscloud_auth_division" in your init_test file as it's used in the tests for this package

[sureshperiyappan]

@sureshperiyappan Don't forget to register the package in main.go so the provider has access to it

Sure, I noticed this while testing will add it.

[sureshperiyappan]

@sureshperiyappan I also just ran the tests there, you need to register "genesyscloud_auth_division" in your init_test file as it's used in the tests for this package

Yes, observed this even after registering this "genesyscloud_auth_division" in the init_test file my Acceptance test is failing, i will investigate and see what else is missing and update code.

[sureshperiyappan]

Looks good! Still just a few outstanding comments to be addressed. The most important being Declan's comment about registering the architect_schedules package in main.go

After you've done that, be sure to run go generate from the root of the project.

Sure, I will run the go generate and do a separate commit and update the PR

[sureshperiyappan]

Looks good @sureshperiyappan, just make sure you add the caching as john mentioned

Yes, i am working on it and will update the PR with that changes.