MyRobotLab / InMoov

inmoov repo
http://myrobotlab.org
87 stars 64 forks source link

Aiml inmoov files disclaimer #186

Open moz4r opened 5 years ago

moz4r commented 5 years ago

While I'm thinking of it, we need to move disclaimer inside a category from every files, because programAB engine delete it. Because sometime it is useful to point licenses type / rights... If it cannot be fixed inside programAB land

<category><pattern>SYSTEM_DISCLAMER</pattern>
<template>
<!--  comments -->
<!--  comments... -->
<!--  etc... -->
</template>
</category>
hairygael commented 5 years ago

Yes the disclaimer is auto produced by programAB, so we could remove it. It keeps the file a little lighter on Git. Gael Langevin Creator of InMoov InMoov Robot http://www.inmoov.fr @inmoov http://twitter.com/inmoov

Le lun. 5 nov. 2018 à 22:31, Anthony notifications@github.com a écrit :

While I'm thinking of it, we need to move disclaimer, before the tag inside every files, because programAB engine delete it ( before tag is ok ). Because sometime it is useful to point licenses type / rights...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MyRobotLab/inmoov/issues/186, or mute the thread https://github.com/notifications/unsubscribe-auth/AIF2xy4LZIY6RPCJx6eyRoEju-BAG_bhks5usK4XgaJpZM4YPTJs .

moz4r commented 5 years ago

I think it's important to indicate the license in each file

moz4r commented 5 years ago

related : https://github.com/MyRobotLab/myrobotlab/issues/340

hairygael commented 5 years ago

Maybe a misunderstanding because of my previous answer. Yes, we need a disclaimer in each files. We can use the auto produced disclaimer using ProgramAb for the default disclaimer and add what is necessary in each file.

Gael Langevin Creator of InMoov InMoov Robot http://www.inmoov.fr @inmoov http://twitter.com/inmoov

Le mer. 21 nov. 2018 à 14:40, Anthony notifications@github.com a écrit :

related : MyRobotLab/myrobotlab#340 https://github.com/MyRobotLab/myrobotlab/issues/340

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MyRobotLab/inmoov/issues/186#issuecomment-440665267, or mute the thread https://github.com/notifications/unsubscribe-auth/AIF2x3qB1jpbmef4ZCUmdDPOYCE7-sZGks5uxVe_gaJpZM4YPTJs .

kwatters commented 5 years ago

We should make it so ProgramAB does not overwrite the AIML files. That seems to me to be the underlying issue here.