MyRobotLab / InMoov

inmoov repo
http://myrobotlab.org
95 stars 66 forks source link

Inmoov shutdown broken #97

Closed moz4r closed 7 years ago

moz4r commented 7 years ago

todo : use stopService() from java land

supertick commented 7 years ago

Runtime.shutdown(sec) not working ?

moz4r commented 7 years ago

Strange issues from python land. The solution to use service related stopService() is cleaner I think

supertick commented 7 years ago

Just to be clear .. stopService stops the threads ... releaseService calls stopService AND purges all scheduled tasks AND removes the service from the registry and publishes events saying the service has been released .. So if you want to completely remove a service use releaseService

moz4r commented 7 years ago

Thank you for info ! I will use release when I want to shutdown . At this time I just put some things inside services shutdown routines related. Like writeAndQuit inside programab. Or rest()+disable inside Inmoov. Goal is to run some tasks when user use the swingui cross.

hairygael commented 7 years ago

Hello guys, This is more a message for Anthony. When InMoov is shutting down (inmoov-develop), it gets back to rest() position, that is good and safe. But after that, it doesn't disable() the servos before shutting down MRL completely. (version MRL 1.0.2340) So, we currently need to manually turn off the power to make sure the servos stop buzzing.

Is it something fixed with more recent versions or does it still remain?

Gael Langevin Creator of InMoov InMoov Robot http://www.inmoov.fr @inmoov http://twitter.com/inmoov

2017-08-19 17:13 GMT+02:00 Anthony notifications@github.com:

Thank you for info ! I will use release when I want to shutdown . At this time I just put some things inside services shutdown routines related. Like writeAndQuit inside programab. Or rest()+disable inside Inmoov. Goal is to run some tasks when user use the swingui cross.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MyRobotLab/inmoov/issues/97#issuecomment-323528946, or mute the thread https://github.com/notifications/unsubscribe-auth/AIF2x3d0z2CO4B1HxzhnrVvOvdQk5Rqxks5sZvuUgaJpZM4OqLWh .

moz4r commented 7 years ago

just tested the last build on whole robot, seem ok. for you too ?

hairygael commented 7 years ago

Hello Anthony, I will not be able to test for a while. My third InMoov is now set on the exhibition. My second InMoov is dismantled in suitcases ready to go to the Makerfaire Eindhoven, and my first InMoov is out of the workshop for a show.

Gael Langevin Creator of InMoov InMoov Robot http://www.inmoov.fr @inmoov http://twitter.com/inmoov

2017-08-27 19:37 GMT+02:00 Anthony notifications@github.com:

Reopened #97 https://github.com/MyRobotLab/inmoov/issues/97.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MyRobotLab/inmoov/issues/97#event-1222856759, or mute the thread https://github.com/notifications/unsubscribe-auth/AIF2x9dylg88FP9r0RBV4HzqC91YH6lqks5scalXgaJpZM4OqLWh .

moz4r commented 7 years ago

aaarg master without InMoov :( You need a fourth inmoov !!! Have fun for Makerfaire

hairygael commented 7 years ago

Thanks Anthony!

Gael Langevin Creator of InMoov InMoov Robot http://www.inmoov.fr @inmoov http://twitter.com/inmoov

2017-08-28 22:15 GMT+02:00 Anthony notifications@github.com:

aaarg master without InMoov :( You need a fourth inmoov !!! Have fun for Makerfaire

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MyRobotLab/inmoov/issues/97#issuecomment-325467466, or mute the thread https://github.com/notifications/unsubscribe-auth/AIF2x7ZuxQGRB1BAlhvFz1knWTRGik7Uks5scx_jgaJpZM4OqLWh .

supertick commented 7 years ago

closing - Gael can re-open if noWorky for him .. Thanks..

hairygael commented 7 years ago

Shutting down is fixed, very good!

Gael Langevin Creator of InMoov InMoov Robot http://www.inmoov.fr @inmoov http://twitter.com/inmoov

2017-09-14 18:38 GMT+02:00 GroG notifications@github.com:

closing - Gael can re-open if noWorky for him .. Thanks..

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MyRobotLab/inmoov/issues/97#issuecomment-329539474, or mute the thread https://github.com/notifications/unsubscribe-auth/AIF2xxEbPfXyOClkxxKrS479HcyVWosxks5siVZ2gaJpZM4OqLWh .