MySiteApp / node-safari-push-notifications

Helper methods for generating resources required by Apple's Safari Push Notifications.
MIT License
23 stars 14 forks source link

Manifest File Creation Fix #17

Closed raymondflores closed 6 years ago

raymondflores commented 6 years ago

new changes for manifest file fixes #16

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 18


Totals Coverage Status
Change from base Build 11: 0.0%
Covered Lines: 65
Relevant Lines: 65

💛 - Coveralls
raymondflores commented 6 years ago

@kobim I reverted the files the test worked on utils.test.js but was breaking for other reason i could not figure out

kobim commented 6 years ago

Where did you see a break?

raymondflores commented 6 years ago

screen shot 2018-08-07 at 2 17 12 pm

I've tried npm install/npm rebuild @kobim

kobim commented 6 years ago

It's strange your nodejs is trying to run the global jest rather then local. Maybe your NODE_ENV is set to production? Try this in the project root (verify your npm version is 5 or above):

rm -rf node_modules/
NODE_ENV=development npm install
npm test

and let me know if you succeed.

raymondflores commented 6 years ago

screen shot 2018-08-08 at 11 09 17 am Did not work @kobim

raymondflores commented 6 years ago

Can you checkout my fork and see if test run well on your side @kobim

raymondflores commented 6 years ago

without this fix this library does not even work

kobim commented 6 years ago

Merged & published to npm. Thank you for your contribution!