search

MyTurn-OpenSource / pyturn

MyTurn implementation with Python backend and HTML/CSS/JavaScript frontend
Other
3 stars 0 forks source link

The first Check Status gave old info on the phone. #1

Closed jcomeauictx closed 6 years ago

jcomeauictx commented 6 years ago

using BLU phone (reported by @DavidStodolsky )

jcomeauictx commented 6 years ago

steps to duplicate please? I just tested with 2 phones and don't see it. @DavidStodolsky

DavidStodolsky commented 6 years ago

This applies to the old interface with the "check status" button - http://uwsgi-alpha.myturn.mobi After the speaker name was updated in Mac Chrome, a "check status" on the phone still showed the old speaker name. The next "check status" on the phone updated the speaker.

jcomeauictx commented 6 years ago

passing the test at https://github.com/MyTurn-OpenSource/pyturn/blob/alpha/apptest.py line 202 shows this shouldn't happen. I'm not saying it didn't, but until I can duplicate it I can't fix it. marking it closed unless new info comes in.

jcomeauictx commented 6 years ago

reopening, just saw it happen:

FAIL: test_issue_1 (__main__.TestMyturnMultiUser)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "apptest.py", line 226, in test_issue_1
    self.assertEqual('alice', status.split()[-1])
AssertionError: 'alice' != 'charlie'
- alice
+ charlie
jcomeauictx commented 6 years ago

it was an intermittent bug in the test itself, not in the server or client code. fixed now, as of commit 982c018.