search

MycroftAI / adapt

Adapt Intent Parser
Apache License 2.0
709 stars 155 forks source link

Requirements in setup.py #10

Closed baudren closed 8 years ago

baudren commented 8 years ago

Thank you for sharing such a nice tool!

Small issue, when installing the code with python setup.py install, not all the requirements come along: setup.py does not refer to the requirements.txt. It would be nicer if it was the case, for packaging.

clusterfudge commented 8 years ago

Agreed. I've done this in previous projects, but it's a naive reading of the requirements.txt file into the install_requires array. Is there something else that's considered a best practice?

clusterfudge commented 8 years ago

I'm going to update just the setup file now, awaiting your response.

baudren commented 8 years ago

The other best practice bit that was missing was from the example codes (not respecting the PEP8 coding standards, whereas the rest of the code seems clean enough). It would be nice to put them in a nicer form, since for many people it will be the first contact with the codebase.

Sudo-Kid commented 8 years ago

On the note of making it a little easier to get in. I made a pull request to have test-requirements.txt pull from requirements.txt.

clusterfudge commented 8 years ago

Ok, nobody actually answered my question here. I've added the correct dependencies/versions to the setup file, and am going to close this.