Guarantee sorted results from IntentDeterminationEngine.determine_intent

MycroftAI / adapt

Adapt Intent Parser

Apache License 2.0

710 stars 154 forks source link

Guarantee sorted results from IntentDeterminationEngine.determine_intent #137

Closed clusterfudge closed 3 years ago

clusterfudge commented 3 years ago

Enumerate all possible parse results if context or regex entities are in play.

Description of what the PR does, such as fixes # {issue number} Fixes #136
Description of how to validate or test this PR Explicit unit test added: IntentEngineTests.testResultsAreSortedByConfidence ./run_tests.sh
Whether you have signed a CLA (Contributor Licensing Agreement) Signed

chrisveilleux commented 3 years ago

My only comment is that this makes Adapt no longer "greedy" when doing the sorting. Is this acceptable? If so, should comments be added to this effect?

clusterfudge commented 3 years ago

@ChristopherRogers1991 updated the comments on IntentDeterminationEngine to incorporate the fact that we're only sometimes greedy.

Also bumped to 0.5.0.

ChristopherRogers1991 commented 3 years ago

I think you probably meant to tag @chrisveilleux.

clusterfudge commented 3 years ago

I think you probably meant to tag @chrisveilleux.

Yup, my bad! Thanks other Chris!