MycroftAI / adapt

Adapt Intent Parser
Apache License 2.0
710 stars 154 forks source link

Allow building adapt with loose requirements #139

Closed PureTryOut closed 2 years ago

PureTryOut commented 3 years ago

The adapt equivalent of https://github.com/MycroftAI/mycroft-core/commit/ff50c4b5ecffc0d81822d8efab404054ca52b492. This allows Linux distributions to ship adapt even though they have newer versions than specified in requirements.txt. Since distributions have to make sure for themselves that their packages work anyway, and this only happens when explicitely specified, this is safe to do. The user has to figure out problems themselves when they use this.

In a clean virtual environment, run MYCROFT_LOOSE_REQUIREMENTS=1 python3 setup.py install and verify if the newest version of all dependencies are installed, rather than the pinned version.

Yes

clusterfudge commented 2 years ago

We've removed all dependencies except six, which already uses a loose requirement. An interesting idea, though!

PureTryOut commented 2 years ago

Oh sorry, you're right. It seems I was still working with the previous release :sweat_smile: