MycroftAI / adapt

Adapt Intent Parser
Apache License 2.0
710 stars 154 forks source link

Fix mycroft-core PR generation #152

Closed krisgesling closed 2 years ago

krisgesling commented 2 years ago

Description

The longer story

The method I used to assign the VERSION environment variable has been deprecated due to a security vulnerability. This switches to the new syntax outlined here. Even with that change, the environment variable doesn't seem to be accessible between jobs, only between steps within the same job.

During my reading, I also discovered that PR's generated directly by Github Actions apparently cannot trigger other Github Actions. So the use of a 3rd account is a recommended way of working around this: https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs

How to test

See Action output here:

CLA

krisgesling commented 2 years ago

Just squashed the commits

krisgesling commented 2 years ago

Yeah I learned some useful things working through this, so figured I'd be coming back here in the future to work out what I did :laughing: