search

MycroftAI / adapt

Adapt Intent Parser
Apache License 2.0
712 stars 154 forks source link

Change license to Apache 2.0 #76

Closed forslund closed 6 years ago

forslund commented 6 years ago

Switch to Apache 2.0 license like the rest of the Mycroft project as requested by @penrods.

forslund commented 6 years ago

I'd like @penrods to look over the change as well so I've added the license in a correct way

forslund commented 6 years ago

Copy-paste issue has been corrected and I removed the __author__ field in a separate commit so it can be merged or disregarded depending on @clusterfudge's response.

clusterfudge commented 6 years ago

My attachment to the author tags is less about insult and more about practicality; it's not uncommon for refactors to rename files, and being able to track down the original author (as opposed to the person who moved the file) is usually quite helpful.

If there's a goal to remove these across the app, or to migrate them to github usernames, I'd be in support of that.

penrods commented 6 years ago

I removed the author tags from mycroft-core when I moved it to Apache 2.0, also, and have been pulling them from the MycroftAI-implemented skills. In those cases, the author tags were a mess -- some were updated by some contributors as they implemented changes, some weren't. And I really couldn't come up with a good definition of "author" in many of the cases -- does someone who makes a one-line bug fix become an author?

clusterfudge commented 6 years ago

Have we considered owners files? I guess that addresses a different set of problems, but interesting food for thought.

If author tags are the way of the past, I bid them farewell.

penrods commented 6 years ago

Looks like Forslund pulled the author changes from this PR anyway. We'll address it later. OWNERS files are new to me -- interesting, although they really do address slightly different concerns.

forslund commented 6 years ago

Yeah, I pulled it out since the discussion was ongoing. I'll submit it as a separate PR.