OAkyildiz commented 6 years ago

82: In the `IntentDeterminationEngine.register_entity(...)` of `adapt/engine.py` registering intent in for loops in the user's code does not look pythonic and interacting that way with the API does not look refined to the end user.

This minor change internalizes the for loop in a very simple way. (also checks the alias_of only once, not in the loop.)

run_tests.py exits with all 48 tests passing. examples/single_intent_parser_entity_list.py contains a modified version of the original example.

I have read the contributing guidelines as well as CoC. I have signed the CLA.

OAkyildiz commented 6 years ago

Hello,

Any updates on this?

forslund commented 5 years ago

@OAkyildiz did you see @clusterfudge's last comment there?

OAkyildiz commented 5 years ago

@forslund, Sorry, I did. But, there are too many things on my plate as of now. (In fact, there are multiple plates in front of me, figuratively speaking)

@clusterfudge, now that you mention buffers... I see where things might go wrong. Could you point me at the similar test cases for the singular version?

clusterfudge commented 3 years ago

Closing as stale.

MycroftAI / adapt

issue-82: register entity lists #83

82: In the `IntentDeterminationEngine.register_entity(...)` of `adapt/engine.py` registering intent in for loops in the user's code does not look pythonic and interacting that way with the API does not look refined to the end user.

MycroftAI / adapt

issue-82: register entity lists #83

82: In the IntentDeterminationEngine.register_entity(...) of adapt/engine.py registering intent in for loops in the user's code does not look pythonic and interacting that way with the API does not look refined to the end user.

82: In the `IntentDeterminationEngine.register_entity(...)` of `adapt/engine.py` registering intent in for loops in the user's code does not look pythonic and interacting that way with the API does not look refined to the end user.