Closed ChristopherRogers1991 closed 5 years ago
Apologies for the delay - I've added a simple unit test for test_resolve_one_of
, which should fail on master but pass on this branch, and I've changed .get
to []
.
Sorry, it's going to take me a while to grok this test (need to revisit what are the inputs and outputs of this method). I think the more practical test is one that makes use of the "at least one" semantics of an intent definition, as opposed to asserting on the outputs of this deep-in-the-bowels method.
@clusterfudge, I've added another test that should hopefully be more straightforward. The key is that a tag (temperature' in the test) needs to be possible in multiple locations (passed in to multiple
one_ofcalls), so that we have to advance to the second possible tag (update
last_end_index`) in one of those locations.
Hey @clusterfudge,
Friendly ping. Let me know if you'd like me to make any other changes.
-Christopher
Cool, last request, please update the version in setup.py to 0.3.3
@clusterfudge, done. The version is now 0.3.3.
Fixes https://github.com/MycroftAI/adapt/issues/91