search

MycroftAI / documentation

Mycroft.AI documentation for all public facing technical components.
https://mycroft.ai/documentation
Apache License 2.0
80 stars 91 forks source link

Issue with conversational-context.md #59

Open Quinn2017 opened 6 years ago

Quinn2017 commented 6 years ago

For an unknown reason, I had an issue with the order of the adds_context and removes_context when working with the "Using context to enable Intents" part of the "conversational-context.md" guide (HERE).

When I answer 'yes' to 'would you like milk with that', I get 'what about honey' to which I respond 'yes' and then the 'you might have to say that a different way'. The same occurs vice versa when I answer 'no' instead of the 'yes'. It only works when I reverse the order of the adds_context and removes_context in the NoMilkIntent and YesMilkIntent -- i.e., when the adds_context comes before the removes_context. I don't know why it should make a difference, and I recall it working in either order sometime ago (but I might be wrong). There are no error messages in the mycroft-cli-client. And I'm using Picroft (Mycroft-Core ver. 18.2.4 beta).

Note that I also needed to make a few fixes for the TeaSkill example to work. See my pull-request (#57) for recommended changes to the "Using context to enable Intents" part of the "conversational-context.md". I did not include this issue in my pull-request (#57) as they seem to be two different problems.

KathyReid commented 5 years ago

I believe this was resolved by #99 - are you happy for me to close this @Quinn2017 ?