MycroftAI / enclosure-mark1

Replacing the faceplate repo
Apache License 2.0
9 stars 8 forks source link

Bug Long mouth image string doesn't work #104

Closed forslund closed 4 years ago

forslund commented 4 years ago

@JarbasAl originally reported that the MycroftMouth::showIcon() method doesn't handle split icon strings correctly.

After debugging we found that the $ sign indicating that a continuation message will be sent isn't stripped from the icon string generating a faulty code.

Additionally the documentation doesn't match the implementation. It states that the followup code should start with a $ instead of end with one.

A basic fix has been created in the bugfix/large-image branch

JarbasAl commented 4 years ago

fixed by #106