Cleaned up compile.sh - Githubissues

MycroftAI / enclosure-mark1

Replacing the faceplate repo

Apache License 2.0

9 stars 8 forks source link

Cleaned up compile.sh #23

Closed MatthewScholefield closed 8 years ago

MatthewScholefield commented 8 years ago

This fixes #22 . This is open for discussion but I've cleaned up the compile.sh script by doing the following:

Removed the printing of all build preferences (the only prints them to the screen. It doesn't save them to a file or anything)
Removed the verbose flag (I don't think this is helpful since it just clogs up the output)
Enabled all warnings (we should look into these)
Changed from machine logging to human logging (we don't need all those strange characters)

jdorleans commented 8 years ago

If there is no relevant information on those logs, it seems good to me. @aatchison do you have any other comment on this?

aatchison commented 8 years ago

I think you are probably right Matthew. Could we add a verbose flag? On Jul 8, 2016 2:23 PM, "jdorleans" notifications@github.com wrote:

Assigned #23 https://github.com/MycroftAI/enclosure/pull/23 to @aatchison https://github.com/aatchison.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MycroftAI/enclosure/pull/23#event-717419428, or mute the thread https://github.com/notifications/unsubscribe/AIJOO2TpgAgvXBjpO2z4H_Eci-4_Lt0nks5qTqOdgaJpZM4JGl2o .

MatthewScholefield commented 8 years ago

@aatchison Mentioned it was alright to leave that flag out since it doesn't add any relevant info so I'm merging.