MycroftAI / enclosure-mark1

Replacing the faceplate repo
Apache License 2.0
9 stars 8 forks source link

Code improvements #28

Closed MatthewScholefield closed 8 years ago

MatthewScholefield commented 8 years ago

This brings in the following changes:

The commits detail more specific changes. Please test to ensure this PR won't have any behavioral differences.

jdorleans commented 8 years ago

@Wolfgange3311999 As we talked before, it's good to have our standard format and use tab instead of space. However, this tab is too long. It seems 8 space long instead of 4. Please, fix that.

MatthewScholefield commented 8 years ago

@jdorleans The tab size is depends on the editor or viewer you are using. For GitHub you can change it like this.

MatthewScholefield commented 8 years ago

OK, I've added the last changes so this is now ready. The license will be added in a separate commit.

MatthewScholefield commented 8 years ago

@jdorleans lgty?

jdorleans commented 8 years ago

@Wolfgange3311999 what are the TimeOne changes? Have you just updated the lib?

MatthewScholefield commented 8 years ago

@jdorleans Yes, I updated the TimerOne library to a different fork that is better maintained and uses an MIT license rather than GPL. This is because there was talk of making the enclosure code MIT licensed although that is in no way final.

jdorleans commented 8 years ago

Let's merge this!