search

MycroftAI / enclosure-mark1

Replacing the faceplate repo
Apache License 2.0
9 stars 8 forks source link

Integrating MycroftDisplay into MycroftMouth #35

Closed MatthewScholefield closed 5 years ago

MatthewScholefield commented 8 years ago

Relies on #33 .

This replaces the MycroftHT1632 class in MycroftMouth with a MycroftDisplay instance.

jdorleans commented 8 years ago

Ok, I'll review this after we merge #33

jdorleans commented 8 years ago

@Wolfgange3311999 rebase this with master, just after you include your #33 changes. You'll notice there will no more need to call render() every time. So please, address the changes.

jdorleans commented 8 years ago

@Wolfgange3311999 please, rebase this branch with master to integrate the change from Display and then we can continue the review process.

MatthewScholefield commented 8 years ago

@jdorleans Ok, I've rebased. I've verified it compiles and will test on a device later today.

penrods commented 5 years ago

Interesting, but too large to pull onto Arduino. Closing unmerged.