MycroftAI / hardware-mycroft-mark-II

Mycroft's Mark II Rpi mechanical, electrical and industrial designs
109 stars 32 forks source link

Improve system update reboot process #39

Open Olzeke51 opened 3 years ago

Olzeke51 commented 3 years ago

Describe the bug this may be a duplicate .....grz IF there wasn't a forced reboot/update at :: "2021-03-23 19:52:15.651 | INFO | 280 | mycroft.client.enclosure.base:on_close:497 | Closing 547483477088" THEN it's possible a "Temperature" request triggered it ..!!????? {{ I did this earlier:: 2021-03-23 18:23:24.554 | INFO | 275 | main:handle_utterance:76 | Utterance: ["what's the temperature"]}} got a good reply ' I don't remember asking for/doing anything with Mycroft till about 22:00 +- UTC The only thing I can think; would be to ask for the Temperate at the reboot time........ . but didn't stick around to see a reboot ....

To Reproduce Steps to reproduce the behavior:

  1. something is wrong with Temperature
  2. Just asked for it [22:21 UTC] got verbal respons, BLUE spinner, and the degrees was in real small font, but clouds okay

Log files '/home/olzeke51/file.dump/mycroft/mycroft_23pm.tar.gz

Environment (:

krisgesling commented 3 years ago

Hey there,

If you've got the latest channel selected in your device settings then you can get updates at any moment that will often require a restart of the device. The timestamp on your homescreen indicates when the mycroft container got built but this one was an update to the board support package - a hardware compatibility layer - so that timestamp won't have changed.

There's a two main things we want to do that are relevant here:

  1. Create a better system to report to developers and end users what has changed in the latest build. This needs to report changes to a whole array of repositories that make up your Mycroft installation.
  2. Add a more intelligent update process. If a device is currently in use, the update should not be applied, or at the very least the user should be prompted to know that an update will be applied and hence their device will restart. More likely though, we delay the update for some period of time and then again check if the device is in use before applying it. Ideally everyone on auto updates gets it applied overnight while they are not needing their device and wakes up to new functionality each morning.

I really don't think the temperature intent would have rebooted the device but if you see anything that really suggests otherwise let us know.